Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block's version verifies only the major version #2285

Merged

Conversation

pnowosie
Copy link
Contributor

Block's protocol version verification checks only the major part of the version

@pnowosie pnowosie requested a review from kirugan November 25, 2024 14:20
blockchain/blockchain.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.30%. Comparing base (c55d90f) to head (2217834).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
blockchain/blockchain.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2285      +/-   ##
==========================================
+ Coverage   75.24%   75.30%   +0.05%     
==========================================
  Files         107      107              
  Lines       11392    11398       +6     
==========================================
+ Hits         8572     8583      +11     
+ Misses       2170     2166       -4     
+ Partials      650      649       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pnowosie pnowosie force-pushed the pnowosie/verify-block-version-only-major-version-is-checked branch from d1f0527 to 9309fb4 Compare November 25, 2024 14:35
blockchain/blockchain.go Outdated Show resolved Hide resolved
@kirugan kirugan merged commit 4c43251 into main Nov 25, 2024
12 of 13 checks passed
@kirugan kirugan deleted the pnowosie/verify-block-version-only-major-version-is-checked branch November 25, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants