Remove obsolete migrations #2306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2306 +/- ##
==========================================
+ Coverage 74.38% 74.72% +0.34%
==========================================
Files 109 109
Lines 11493 11187 -306
==========================================
- Hits 8549 8360 -189
+ Misses 2278 2196 -82
+ Partials 666 631 -35 ☔ View full report in Codecov by Sentry. |
Functions in the blockchain package with a db.Transaction argument are intended to be private function since blockchain package is one of the few packages allowed to modify the DB.
Functions in the blockchain package with a db.Transaction argument are intended to be private function since blockchain package is one of the few packages allowed to modify the DB.
Functions in the blockchain package with a db.Transaction argument are intended to be private function since blockchain package is one of the few packages allowed to modify the DB.
IronGauntlets
force-pushed
the
kirugan/remove-obsolete-migrations
branch
from
cefd469 to
5f2809d
Compare
IronGauntlets
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
I have rebased the branch on top of main and made some functions in blockchain private.
Also, I don't think startSchemaVersion needs to be updated since it should have been 16 before (please confirm I am correct).
Also, please don't squash and merge, instead rebase and merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.