[RPC] getStateUpdate #365
Merged
[RPC] getStateUpdate #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the database manager with the marshal and unmarshal functions from protobuf definitions. Use Felt instead its hex representation for storage diffs maps.
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
==========================================
- Coverage 92.12% 91.82% -0.30%
==========================================
Files 66 67 +1
Lines 7083 7228 +145
==========================================
+ Hits 6525 6637 +112
- Misses 554 585 +31
- Partials 4 6 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
adriantpaez
requested review from
stdevMac,
tshakalekholoane,
IronGauntlets and
joshklop
as code owners
stdevMac
approved these changes
Aug 26, 2022
Use github.com/stretchr/testify/assert instead of gotest.tools/assert
Use gotest.tools/assert instead of github.com/stretchr/testify/assert
tshakalekholoane
approved these changes
Aug 29, 2022
joshklop
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #364
Resolves #353
Description
The
starknet_getStateUpdateRPC endpoint returnsFeltvalues as decimal representation when we need it to return them as hexadecimal. Also, I introduce some improvements to the StateUpdate flow (get-save-serve).Changes:
sync.protofile to manage all database marshal and unmarshal processes forStateUpdateStateDifftoStateUpdateFeltas a key inStorageDiffmap instead ofstringBlockHashinstateUpdateResponseToStateDifffunctionValue()method toFeltto get the value referenced by a pointer toFeltTypes of changes
Testing
Requires testing: Yes
Did you write tests??: No. I test the output of
starkent_getStateUpdateby hand and all the errors are fixed. In the future, we need to add unit tests to this.Documentation
If this requires a documentation update, did you add one? No. The documentation is already on
main