Merge remote-tracking branch 'origin/master' into feature/eth_multicall

NethermindEth · Apr 29, 2024 · 1d6874d · 1d6874d
2 parents 3a3e115 + 9dba25a
commit 1d6874d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 17 deletions.
diff --git a/.github/workflows/publish-packages.yml b/.github/workflows/publish-packages.yml
@@ -43,7 +43,7 @@ jobs:
           awk -i inplace -v n=1 '/hash/ { if (++count == n) sub(/hash.*/, "hash='$arm64_hash'"); } 1' debian/postinst
           awk -i inplace -v n=2 '/hash/ { if (++count == n) sub(/hash.*/, "hash='$x64_hash'"); } 1' debian/postinst
 
-          changelog="nethermind ($version) jammy; urgency=high\n"
+          changelog="nethermind ($version) noble; urgency=high\n"
           changelog+="  * Nethermind v$version\n"
           changelog+=" -- Nethermind <devops@nethermind.io>  $(date -R)"
           echo -e "$changelog" > debian/changelog
@@ -74,8 +74,8 @@ jobs:
           echo ${{ secrets.PPA_COPY_TOKEN }} | base64 --decode > /tmp/lp_credentials
           git clone https://git.launchpad.net/ubuntu-archive-tools
           cd ubuntu-archive-tools
-          for release in "focal" "mantic"; do
-            python3 copy-package -y -b -p nethermindeth --ppa-name=nethermind -s jammy --to-suite=$release nethermind
+          for release in "focal" "mantic" "jammy"; do
+            python3 copy-package -y -b -p nethermindeth --ppa-name=nethermind -s noble --to-suite=$release nethermind
           done
           rm -f /tmp/lp_credentials
 

diff --git a/.github/workflows/update-docs.yml b/.github/workflows/update-docs.yml
@@ -57,7 +57,7 @@ jobs:
         env:
           GH_TOKEN: ${{ secrets.REPOSITORY_DISPATCH_TOKEN }}
         run: |
-          version=${{ github.event_name == 'release' && join(' of v', github.event.release.tag_name) || '' }}
+          version="${{ github.event_name == 'release' && format(' of v{0}', github.event.release.tag_name) || '' }}"
           head_branch=feature/auto-update-${{ github.run_number }}-${{ github.run_attempt }}
           git config user.name "${{ github.actor }}"
           git config user.email "${{ github.actor }}@users.noreply.github.com"

diff --git a/src/Nethermind/Nethermind.Core.Test/Crypto/EthereumEcdsaTests.cs b/src/Nethermind/Nethermind.Core.Test/Crypto/EthereumEcdsaTests.cs
@@ -73,18 +73,5 @@ public void Sign_generic_network()
             Address? address = ecdsa.RecoverAddress(tx);
             Assert.That(address, Is.EqualTo(key.Address));
         }
-
-        [Test]
-        public void Recover_kovan([Values(false, true)] bool eip155)
-        {
-            EthereumEcdsa singEcdsa = new(BlockchainIds.Mainnet, LimboLogs.Instance);
-            PrivateKey key = Build.A.PrivateKey.TestObject;
-            Transaction tx = Build.A.Transaction.TestObject;
-            singEcdsa.Sign(key, tx, eip155);
-
-            EthereumEcdsa recoverEcdsa = new(BlockchainIds.Kovan, LimboLogs.Instance);
-            Address? address = recoverEcdsa.RecoverAddress(tx, true);
-            Assert.That(address, Is.EqualTo(key.Address));
-        }
     }
 }