Fix commit in ClientVersionV1 to have only 4 bytes of info following …

…the spec (#7013)
NethermindEth · May 14, 2024 · bfd7c95 · bfd7c95
1 parent 4bb0df2
commit bfd7c95
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/Nethermind/Nethermind.Core/ProductInfo.cs b/src/Nethermind/Nethermind.Core/ProductInfo.cs
@@ -4,8 +4,10 @@
 using System;
 using System.Linq;
 using System.Reflection;
+using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
+[assembly: InternalsVisibleTo("Nethermind.Merge.Plugin.Test")]
 namespace Nethermind.Core;
 
 public static class ProductInfo
@@ -39,7 +41,7 @@ static ProductInfo()
 
     public static string ClientCode { get; }
 
-    public static string Commit { get; }
+    public static string Commit { get; internal set; }
 
     public static string Name { get; }
 

diff --git a/src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.V1.cs b/src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.V1.cs
@@ -1520,6 +1520,7 @@ await rpc.engine_forkchoiceUpdatedV1(forkChoiceState1,
     [Test]
     public async Task Should_return_ClientVersionV1()
     {
+        ProductInfo.Commit = "0000000000000000000000000000000000000000000000000000000000000000";
         using MergeTestBlockchain chain = await CreateBlockchain();
         IEngineRpcModule rpcModule = CreateEngineModule(chain);
         ResultWrapper<ClientVersionV1[]> result = rpcModule.engine_getClientVersionV1(new ClientVersionV1());

diff --git a/src/Nethermind/Nethermind.Merge.Plugin/Data/ClientVersionV1.cs b/src/Nethermind/Nethermind.Merge.Plugin/Data/ClientVersionV1.cs
@@ -16,7 +16,7 @@ public ClientVersionV1()
         Code = ProductInfo.ClientCode;
         Name = ProductInfo.Name;
         Version = ProductInfo.Version;
-        Commit = ProductInfo.Commit;
+        Commit = ProductInfo.Commit[..8];
     }
 
     public string Code { get; }