Add support for eth/67 #4561
Merged
Add support for eth/67 #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Nethermind/Nethermind.Network/ProtocolsManager.cs
# Conflicts: # src/Nethermind/Nethermind.Init/Steps/InitializeNetwork.cs
asdacap
reviewed
Oct 10, 2022
| switch (message.PacketType) | ||
| { | ||
| case Eth66MessageCode.GetNodeData: | ||
| break; |
There was a problem hiding this comment.
So essentially, it will just timeout on their end?
There was a problem hiding this comment.
hmm, good point, I will rethink it
There was a problem hiding this comment.
Spec obligates us to remove message types GetNodeData and NodeData from the eth protocol, is not specifying our exact behaviour:
https://eips.ethereum.org/EIPS/eip-4938#specification
So I think we should do the same as we do when receiving other not supported messages - ignore without respond
asdacap
approved these changes
Oct 10, 2022
LukaszRozmej
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! DO NOT MERGE IT BEFORE ##4475!!!
PR mentioned above is needed for snap sync healing phase after dropping
GetNodeDataEIP: https://eips.ethereum.org/EIPS/eip-4938
Changes:
snapprotocol is enabledTypes of changes
Testing
Requires testing
In case you checked yes, did you write tests??