-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added free space check for healthchecks and node shutdown when free s… #4837
Added free space check for healthchecks and node shutdown when free s… #4837
Conversation
…pace falls below a configurable threshold.
src/Nethermind/Nethermind.Core/MessageBus/SimpleInMemoryMessageBus.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all this messagebus and friends can be simplified with simple Environment.Exit
src/Nethermind/Nethermind.HealthChecks/IAvailableSpaceGetter.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.HealthChecks/IAvailableSpaceGetter.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will 1% be enough on average disk to close the node and save all state?
…pace falls below a configurable threshold.
Resolves #4325
Changes:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Further comments (optional)
Tested on Windows, Ubuntu (VM and WSL) and Docker
For Docker, please note that when data folder is not mapped to an external volume, drive information will reflect the size of the virtual drive, which may not correspond to physical space.