-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add point evaluation precompile #4890
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flcl42
force-pushed
the
feature/point-evaluation-precompile
branch
from
November 11, 2022 09:11
8348692
to
b511e62
Compare
flcl42
changed the base branch from
master
to
feature/add-blob-spec-fork-and-fields
November 13, 2022 14:21
flcl42
changed the base branch from
feature/add-blob-spec-fork-and-fields
to
master
November 13, 2022 15:00
flcl42
changed the base branch from
master
to
feature/add-blob-spec-fork-and-fields
November 13, 2022 16:01
flcl42
force-pushed
the
feature/add-blob-spec-fork-and-fields
branch
from
November 16, 2022 08:06
4bd1ec1
to
b520aad
Compare
flcl42
force-pushed
the
feature/point-evaluation-precompile
branch
from
November 16, 2022 09:20
b511e62
to
207c6c9
Compare
flcl42
force-pushed
the
feature/point-evaluation-precompile
branch
4 times, most recently
from
November 16, 2022 15:13
2944ee6
to
aa3aba6
Compare
flcl42
force-pushed
the
feature/add-blob-spec-fork-and-fields
branch
3 times, most recently
from
November 24, 2022 12:15
8a8c6f8
to
f1cff71
Compare
flcl42
force-pushed
the
feature/point-evaluation-precompile
branch
from
November 24, 2022 12:58
aa3aba6
to
0c73eb9
Compare
flcl42
force-pushed
the
feature/add-blob-spec-fork-and-fields
branch
2 times, most recently
from
November 24, 2022 13:08
71b85d4
to
e3ae084
Compare
flcl42
force-pushed
the
feature/point-evaluation-precompile
branch
from
November 24, 2022 13:10
0c73eb9
to
c2ef839
Compare
flcl42
force-pushed
the
feature/point-evaluation-precompile
branch
2 times, most recently
from
November 24, 2022 14:20
64618b0
to
feb6a9c
Compare
LukaszRozmej
requested changes
Jan 19, 2023
src/Nethermind/Nethermind.Evm/Precompiles/PointEvaluationPrecompile.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm.Test/PointEvaluationPrecompileTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm.Test/PointEvaluationPrecompileTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/Precompiles/PointEvaluationPrecompile.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Crypto/Properties/kzg_trusted_setup.txt
Outdated
Show resolved
Hide resolved
flcl42
force-pushed
the
feature/add-datahash-opcode
branch
from
January 20, 2023 15:35
2e1fe41
to
4c84274
Compare
flcl42
force-pushed
the
feature/point-evaluation-precompile
branch
from
January 21, 2023 16:44
1b022e0
to
0dd4f35
Compare
flcl42
force-pushed
the
feature/point-evaluation-precompile
branch
from
January 22, 2023 14:12
e61941a
to
6fe2983
Compare
… fallback to actual use.
LukaszRozmej
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please build package & docker and check if they initialize correctly on 4844 and non-4844 networks before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4867, #4894
Changes:
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Needs testing on different platforms