Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add point evaluation precompile #4890

Merged
merged 15 commits into from
Feb 2, 2023
Merged

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Nov 11, 2022

Depends on #4867, #4894

Changes:

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Needs testing on different platforms

@flcl42 flcl42 force-pushed the feature/point-evaluation-precompile branch from 8348692 to b511e62 Compare November 11, 2022 09:11
@flcl42 flcl42 changed the base branch from master to feature/add-blob-spec-fork-and-fields November 13, 2022 14:21
@flcl42 flcl42 marked this pull request as ready for review November 13, 2022 14:45
@flcl42 flcl42 changed the base branch from feature/add-blob-spec-fork-and-fields to master November 13, 2022 15:00
@flcl42 flcl42 changed the base branch from master to feature/add-blob-spec-fork-and-fields November 13, 2022 16:01
@flcl42 flcl42 marked this pull request as draft November 13, 2022 16:02
@flcl42 flcl42 force-pushed the feature/add-blob-spec-fork-and-fields branch from 4bd1ec1 to b520aad Compare November 16, 2022 08:06
@flcl42 flcl42 force-pushed the feature/point-evaluation-precompile branch from b511e62 to 207c6c9 Compare November 16, 2022 09:20
@flcl42 flcl42 marked this pull request as ready for review November 16, 2022 09:20
@flcl42 flcl42 force-pushed the feature/point-evaluation-precompile branch 4 times, most recently from 2944ee6 to aa3aba6 Compare November 16, 2022 15:13
@rubo rubo added the eip label Nov 18, 2022
@flcl42 flcl42 marked this pull request as draft November 23, 2022 12:41
@flcl42 flcl42 force-pushed the feature/add-blob-spec-fork-and-fields branch 3 times, most recently from 8a8c6f8 to f1cff71 Compare November 24, 2022 12:15
@flcl42 flcl42 force-pushed the feature/point-evaluation-precompile branch from aa3aba6 to 0c73eb9 Compare November 24, 2022 12:58
@flcl42 flcl42 marked this pull request as ready for review November 24, 2022 12:59
@flcl42 flcl42 force-pushed the feature/add-blob-spec-fork-and-fields branch 2 times, most recently from 71b85d4 to e3ae084 Compare November 24, 2022 13:08
@flcl42 flcl42 force-pushed the feature/point-evaluation-precompile branch from 0c73eb9 to c2ef839 Compare November 24, 2022 13:10
@flcl42 flcl42 requested a review from MarekM25 November 24, 2022 13:10
@flcl42 flcl42 force-pushed the feature/point-evaluation-precompile branch 2 times, most recently from 64618b0 to feb6a9c Compare November 24, 2022 14:20
@flcl42 flcl42 marked this pull request as draft November 25, 2022 11:48
@flcl42 flcl42 marked this pull request as draft January 17, 2023 10:16
@flcl42 flcl42 marked this pull request as ready for review January 19, 2023 09:51
@flcl42 flcl42 force-pushed the feature/add-datahash-opcode branch from 2e1fe41 to 4c84274 Compare January 20, 2023 15:35
Base automatically changed from feature/add-datahash-opcode to master January 21, 2023 15:51
@flcl42 flcl42 force-pushed the feature/point-evaluation-precompile branch from 1b022e0 to 0dd4f35 Compare January 21, 2023 16:44
@flcl42 flcl42 closed this Jan 22, 2023
@flcl42 flcl42 force-pushed the feature/point-evaluation-precompile branch from e61941a to 6fe2983 Compare January 22, 2023 14:12
@flcl42 flcl42 reopened this Jan 22, 2023
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please build package & docker and check if they initialize correctly on 4844 and non-4844 networks before merging

@flcl42 flcl42 merged commit 1b6f5ac into master Feb 2, 2023
@flcl42 flcl42 deleted the feature/point-evaluation-precompile branch February 2, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants