Fix gapless reverse blockheader search #5018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdacap
reviewed
Dec 15, 2022
| @@ -946,14 +946,48 @@ public BlockHeader[] FindHeaders(Keccak? blockHash, int numberOfBlocks, int skip | |||
|
|
|||
| if (skip == 0) | |||
| { | |||
| static BlockHeader[] FindHeadersReversedFast(BlockTree tree, BlockHeader startHeader, int numberOfBlocks, bool reverse = false) | |||
There was a problem hiding this comment.
To be closer to only place where it is used.
asdacap
reviewed
Dec 15, 2022
asdacap
reviewed
Dec 15, 2022
| AddToMain(blockTree, block0); | ||
| AddToMain(blockTree, block1); | ||
| AddToMain(blockTree, block2); | ||
| AddToMain(blockTree, block3); | ||
| AddToMain(blockTree, block4); |
There was a problem hiding this comment.
Why this did not catch the issue before? Should you update this test somehow on line 444?
There was a problem hiding this comment.
BlockTree didn't have any blocks past the requested one, which caused endBlock - how it was previously calculated to always be null
asdacap
approved these changes
Dec 15, 2022
MarekM25
pushed a commit
that referenced
this pull request
Dec 16, 2022
* Fix gapless reverse blockheader search * Increase times to stabilize pipeline * Revert "Increase times to stabilize pipeline" This reverts commit 69193f0. * disable EngineModuleTests parallelization * Revert "disable EngineModuleTests parallelization" This reverts commit 0238cd6. * fix tests (cherry picked from commit d3c4e3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5017
Changes:
GetBlockHeadersto properly supportreverseflag.Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??