Reduce RAM consumption for ForceProcessing requests #5090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
O(N) to O(1) in case of processing requests, also reduced storage space requirements for alternative approach
asdacap
reviewed
Jan 4, 2023
asdacap
approved these changes
Jan 4, 2023
LukaszRozmej
reviewed
Jan 5, 2023
| do | ||
| { | ||
| blocksToBeAddedToMain.Add(toBeProcessed); | ||
| iterations++; | ||
| if (!options.ContainsFlag(ProcessingOptions.ForceProcessing)) |
There was a problem hiding this comment.
can we create a variable for that?
Comment on lines
+621
to
+622
| bool notReachedTheReorgBoundary = (options & ProcessingOptions.Trace) == ProcessingOptions.Trace | ||
| && (branchingPoint.Number > (_blockTree.Head?.Header.Number ?? 0)); |
There was a problem hiding this comment.
better naming needed, now notReachedTheReorgBoundary is actually trace Or notReachedTheReorgBoundary
LukaszRozmej
reviewed
Jan 5, 2023
|
@LukaszRozmej @OlegJakushkin How about those unit tests which should be added? |
kamilchodola
added a commit
that referenced
this pull request
Jan 13, 2023
This reverts commit 44ba349.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces RAM consumption for ForceProcessing requests. Keeping original flow and logic that can be updated in the future.
Changes
Minimal flag checks
Types of changes
flag checks added
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Covered by existing tests