Feature/streaming jsonrpc batch request #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e/streaming-jsonrpc-batch-request
LukaszRozmej
approved these changes
Jan 12, 2023
| { | ||
| if (result.IsCollection) | ||
| await using MemoryStream resultData = new(); |
There was a problem hiding this comment.
As we are doing such a great job already, maybe we can drop this allocation too? To some reused buffer.
There was a problem hiding this comment.
We can do in next PR though
There was a problem hiding this comment.
My ideas are to implement either Stream or TextWriter based on IByteBuffer and use PooledByteBufferAllocator
…request' into feature/streaming-jsonrpc-batch-request
| await _handler.SendRawAsync(_jsonOpeningBracket); | ||
| await foreach (JsonRpcResult.Entry innerResult in result.BatchedResponses!) | ||
| { | ||
| if (!isFirst) await _handler.SendRawAsync(_jsonComma); |
There was a problem hiding this comment.
If we dig deeper, we find:
- In
IpcSocketsHandler,_socket.SendAsync(data, SocketFlags.None), not sure if we should setSocketFlags.TruncatedorSocketFlags.Partialuntil we send_jsonClosingBracket. - In
WebSocketHandlerwe have_webSocket.SendAsync(data, WebSocketMessageType.Text, true, CancellationToken.None), maybe we should setendOfMessagetofalseuntil we send_jsonClosingBracket.
deffrian
pushed a commit
that referenced
this pull request
Jan 16, 2023
* Refactor to use a single batched collection * Using another jsonrpc response * Make unit test compile * So now trying enumerable * Fix test compilation * some refactor * fix test * Fix test * Fix whitespace * tiny improvements * Second time I missed this exact same bug * Fix may break websocket Co-authored-by: lukasz.rozmej <lukasz.rozmej@gmail.com>
kamilchodola
pushed a commit
that referenced
this pull request
Jan 18, 2023
* Refactor to use a single batched collection * Using another jsonrpc response * Make unit test compile * So now trying enumerable * Fix test compilation * some refactor * fix test * Fix test * Fix whitespace * tiny improvements * Second time I missed this exact same bug * Fix may break websocket Co-authored-by: lukasz.rozmej <lukasz.rozmej@gmail.com>
Andrew-Pohl
pushed a commit
to fuseio/nethermind
that referenced
this pull request
Apr 18, 2023
* Refactor to use a single batched collection * Using another jsonrpc response * Make unit test compile * So now trying enumerable * Fix test compilation * some refactor * fix test * Fix test * Fix whitespace * tiny improvements * Second time I missed this exact same bug * Fix may break websocket Co-authored-by: lukasz.rozmej <lukasz.rozmej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
IEnumerableofJsonRpcResult.Entry, allowing lazy and streaming processing of batched reuest.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing