Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of compare specs test & ChiadoSpecProvider #5541

Merged
merged 5 commits into from
Apr 6, 2023

Conversation

MarekM25
Copy link
Contributor

@MarekM25 MarekM25 commented Apr 6, 2023

Changes

  • Added ChiadoSpecProvider
  • Refactored CompareSpecs

The idea was to avoid common chainspec configuration mistakes. We misconfigured maxCodeTransition for testntes many times. This PR hasn't handled Gnosis-specific Shanghai exceptions yet. This PR will give us better control on EIPs exceptions between Gnosis, Chiado <> Mainnet.

The "fun" issue founded by this test:
There is a difference in Chiado and Gnosis/Mainnet specs. Chiado enabled EIP1283 and didn't disable it. While all other networks don't enable this EIP or disable it in one of the hardforks.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • [] No

Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires testing and you already have the tests written. Why did you mark that section as "no" in the description? 🙂

@MarekM25
Copy link
Contributor Author

MarekM25 commented Apr 6, 2023

This requires testing and you already have the tests written. Why did you mark that section as "no" in the description? 🙂

Fixed PR description ;) well it doesn't not requires testing, because the changes are only in tests classes, but indeed I wrote new tests :)

@MarekM25 MarekM25 merged commit 151d9b7 into master Apr 6, 2023
@MarekM25 MarekM25 deleted the gnosis_shanghai_test branch April 6, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants