Refactoring of compare specs test & ChiadoSpecProvider #5541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The idea was to avoid common chainspec configuration mistakes. We misconfigured
maxCodeTransition
for testntes many times. This PR hasn't handled Gnosis-specific Shanghai exceptions yet. This PR will give us better control on EIPs exceptions between Gnosis, Chiado <> Mainnet.The "fun" issue founded by this test:
There is a difference in Chiado and Gnosis/Mainnet specs. Chiado enabled EIP1283 and didn't disable it. While all other networks don't enable this EIP or disable it in one of the hardforks.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?