Prometheus metrics improvements #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deffrian
changed the title
benaadams
approved these changes
Apr 24, 2023
|
|
||
| Db.Metrics.DbSize = _api.DbProvider!.RegisteredDbs.Values.Aggregate(0L, (sum, db) => sum + db.GetSize()); | ||
| } | ||
| catch (Exception e) |
There was a problem hiding this comment.
Why this is general Exception and what are the options? In other words Why can try fail?
| @@ -230,6 +230,8 @@ protected internal void UpdateWriteMetrics() | |||
| Metrics.OtherDbWrites++; | |||
| } | |||
|
|
|||
| public long GetSize() => long.Parse(_db.GetProperty("rocksdb.total-sst-files-size")); | |||
There was a problem hiding this comment.
How long does it take to do 1000 of such gets while DB is being modified?
There was a problem hiding this comment.
I didn't measure. But it's executed once per 5 seconds. So it shouldn't affect overall performance.
There was a problem hiding this comment.
If it would take 0.5 seconds or be heavy on disc IO it would, please measure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
#5553
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?