Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Environment.TickCount64 rather than StopWatch.GetTimestamp #5575

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Use Environment.TickCount64 rather than StopWatch.GetTimestamp #5575

merged 1 commit into from
Apr 17, 2023

Conversation

benaadams
Copy link
Member

Changes

  • Environment.TickCount64 is already in milliseconds whereas StopWatch.GetTimestamp needs conversion based on StopWatch.Frequency (isn't the same Ticks as DateTime Ticks)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams added the bug label Apr 16, 2023
@benaadams benaadams requested a review from LukaszRozmej April 16, 2023 16:33
@LukaszRozmej LukaszRozmej merged commit 5103c6a into master Apr 17, 2023
@LukaszRozmej LukaszRozmej deleted the Use-Environment.TickCount64-rather-than-StopWatch.GetTimestamp branch April 17, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej