Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero total difficulty in FindBlock #5581

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Zero total difficulty in FindBlock #5581

merged 2 commits into from
Apr 20, 2023

Conversation

deffrian
Copy link
Contributor

Fixes Closes Resolves #
#5519

Changes

  • If td for given block inside blockInfos db is zero we will set td to null even if it should be zero. This pr checks genesis difficulty and ttd to set td of this block.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@deffrian deffrian linked an issue Apr 18, 2023 that may be closed by this pull request
Zero td failure while reading td from db #5519
Closed
@deffrian deffrian merged commit 14a790e into master Apr 20, 2023
@deffrian deffrian deleted the 5519-zero-td-failure-while-reading-td-from-db branch April 20, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zero td failure while reading td from db
2 participants
@deffrian @benaadams