Modernise C#

[benaadams]

Changes

• Use range syntax for .Substring and Slice
• Compound assignment statements like ??= null check assign operator
• Use Array.Empty<T>() where appropriate
• Use .Contains rather than .IndexOf(...) < 0
• Don't throw from inside finally block
• Move type declaration into out param
• Use is not where appropriate
• Improved use around ValueTuples
• ContainsKey+Remove on dict to just Remove as it returns bool
• Use _ discards where the result is ignored
• Use full pattern matching for type checking + use
• Use more efficient char '@' string param methods than "@" string where only one char
• Use ?. null conditional operator rather than more verbose checking

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No