Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodules #5611

Merged
merged 1 commit into from
May 1, 2023
Merged

Update submodules #5611

merged 1 commit into from
May 1, 2023

Conversation

benaadams
Copy link
Member

Changes

  • Update submodules

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams added the dependencies Pull requests that update a dependency file label Apr 24, 2023
marcindsobczak
marcindsobczak reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@marcindsobczak marcindsobczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update of tests is fine (there are even 2 new commits now 😄), not sure what about point evaluation precompile @flcl42

@benaadams
Copy link
Member Author

Update of tests is fine (there are even 2 new commits now 😄), not sure what about point evaluation precompile @flcl42

Re-updated and took out precompile updates

@benaadams benaadams requested a review from marcindsobczak May 1, 2023 09:08
@LukaszRozmej LukaszRozmej merged commit e525df8 into master May 1, 2023
@LukaszRozmej LukaszRozmej deleted the submodules branch May 1, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@flcl42 flcl42 Awaiting requested review from flcl42

@marcindsobczak marcindsobczak Awaiting requested review from marcindsobczak

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benaadams @LukaszRozmej @marcindsobczak