Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Nethermind.Native project #5615

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Remove Nethermind.Native project #5615

merged 5 commits into from
Apr 26, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Apr 24, 2023

Changes

  • Replaced Nethermind.Crypto.Bls.ShamatarLib with the new Nethermind.Crypto.Pairings NuGet package
  • Revised namings. Hence, the big number of changed files. NO functionality changes in our code.
    • Dropped Shamatar naming everywhere to eliminate any confusion
    • Changed BN256 to the correct BN254 one everywhere (metrics included)
  • Removed Nethermind.Native project as no longer needed

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

The current EVM tests cover this.

Remarks

With this PR, we no longer have any native libraries in this repo. All those libraries are packed in their NuGet packages respectively.

The package source code is available here.

@rubo rubo marked this pull request as draft April 24, 2023 22:42
@rubo rubo force-pushed the feature/native-loader-removal branch from 88489c1 to ece72d9 Compare April 25, 2023 20:54
@rubo rubo force-pushed the feature/native-loader-removal branch from ece72d9 to b9e64be Compare April 26, 2023 09:27
@LukaszRozmej
Copy link
Member

Where does Nethermind.Crypto.Pairings live?
Maybe we should add into our Readme file all the other repos/packages that are related?

@rubo rubo requested review from LukaszRozmej and benaadams April 26, 2023 11:54
@rubo
Copy link
Contributor Author

rubo commented Apr 26, 2023

@LukaszRozmej The package source code is indicated in the Remarks section. Also, all Nethermind packages follow NuGet guidelines and best practices and have all the info needed on their NuGet page. The link to that page is in the description. No need to bloat README with that stuff.

@rubo rubo marked this pull request as ready for review April 26, 2023 11:58
@rubo rubo merged commit 073357b into master Apr 26, 2023
@rubo rubo deleted the feature/native-loader-removal branch April 26, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants