-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Environment.Exit with ProcessExitSource and cancelation token #5624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick and one more important comment.
@@ -38,8 +38,11 @@ public static void CancelDisposeAndClear(ref CancellationTokenSource? cancellati | |||
{ | |||
source.Cancel(); | |||
source.Dispose(); | |||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nitpick: the CompareExchange
above can be replaced with Exchange
as you always get the previous value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well depends, if someone would have swapped it for something else by then, then we could break that logic.
…cking for free space on startup.
This reverts commit a96c292.
Unfortunately didn't fix: Test Run Aborted with error System.Exception: One or more errors occurred. |
Potentially Fixes #5298
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?