Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tags to every metric #5625

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Add tags to every metric #5625

merged 5 commits into from
Apr 28, 2023

Conversation

deffrian
Copy link
Contributor

Fixes Closes Resolves #
To make requests like avg(state_db_size{Network="Gnosis",Version=~"1.18.0.*"} possible we have to add tags to every metric

Changes

  • Adds tag to every metric
  • Changes BuildTimestamp to unix seconds

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@deffrian deffrian requested a review from LukaszRozmej April 28, 2023 11:40
LukaszRozmej
LukaszRozmej approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this bloat prometheus too much?

@deffrian deffrian merged commit 731cd42 into master Apr 28, 2023
@deffrian deffrian deleted the feature/metrics-tags branch April 28, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deffrian @LukaszRozmej