Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullability in Api #5631

Merged
merged 1 commit into from
May 1, 2023
Merged

Enable nullability in Api #5631

merged 1 commit into from
May 1, 2023

Conversation

deffrian
Copy link
Contributor

@deffrian deffrian commented May 1, 2023

Fixes Closes Resolves #
Enables strict null checks in Nethermind.Api

Changes

  • NethermindApi now have constructor
  • Few fields made nullable

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@deffrian deffrian marked this pull request as ready for review May 1, 2023 03:05
@deffrian deffrian merged commit 04bda6f into master May 1, 2023
@deffrian deffrian deleted the enable-nullability-api branch May 1, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deffrian @benaadams