refactor state and storage behind one interface #5659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LukaszRozmej @Scooletz now worldState delegates to internal classes StateProvider PersistentStorageProvider TransientStorageProvider |
tanishqjasoria
force-pushed
the
world-state-rebase
branch
from
4d50f85 to
af63cd0
Compare
asdacap
reviewed
May 10, 2023
asdacap
reviewed
May 10, 2023
| @@ -332,7 +332,7 @@ private static async Task RunBenchmarkBlocks() | |||
| if (allocation.Code != null) | |||
| { | |||
| Keccak codeHash = stateProvider.UpdateCode(allocation.Code); | |||
| stateProvider.UpdateCodeHash(address, codeHash, specProvider.GenesisSpec); | |||
| stateProvider.InsertCode(address, codeHash, specProvider.GenesisSpec); | |||
There was a problem hiding this comment.
Isn't the second param the code itself?
There was a problem hiding this comment.
ahh, yes - my bad
There was a problem hiding this comment.
which solution is this a part of? i cant find the file in any solution
asdacap
approved these changes
May 10, 2023
yes, works fine! |
LukaszRozmej
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5329
Replaces #5533
some interface and API changes for integrating verkle trees with nethermind.
Also, bring state access under limited interfaces across the solution.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
synced a node using snap sync and let it run for a few hours after syncing - everything looked normal