Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align only in peer report #5667

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

deffrian
Copy link
Contributor

@deffrian deffrian commented May 8, 2023

Fixes Closes Resolves #
#5657

Changes

  • Align port and ip only when printing peer report
  • A bit of refactoring

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@deffrian deffrian linked an issue May 8, 2023 that may be closed by this pull request
@deffrian deffrian marked this pull request as ready for review May 8, 2023 18:03
@deffrian deffrian requested a review from a team as a code owner May 8, 2023 18:03
Copy link
Contributor

@asdacap asdacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -196,5 +197,15 @@ public static NodeClientType RecognizeClientType(string clientId)
return NodeClientType.Unknown;
}
}

public struct Format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public static class would be better?

@deffrian deffrian merged commit 99b2ac3 into master May 9, 2023
@deffrian deffrian deleted the 5657-admin_peers-return-invalid-enode-url branch May 9, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin_peers return invalid enode url
4 participants