Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misplaced arguments #5668

Merged
merged 1 commit into from
May 9, 2023
Merged

Fix misplaced arguments #5668

merged 1 commit into from
May 9, 2023

Conversation

deffrian
Copy link
Contributor

@deffrian deffrian commented May 9, 2023

Fixes Closes Resolves #
#5650

Changes

  • Swap args in ternary condition

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@deffrian deffrian requested a review from a team as a code owner May 9, 2023 03:32
@deffrian deffrian linked an issue May 9, 2023 that may be closed by this pull request
CLI: node.switchLocal: System.UriFormatException: Invalid URI: The format of the URI could not be determined. #5650
Closed
asdacap
asdacap approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@asdacap asdacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

@LukaszRozmej LukaszRozmej merged commit 627ca88 into master May 9, 2023
@LukaszRozmej LukaszRozmej deleted the 5650-cli-nodeswitchlocal-exception branch May 9, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@asdacap asdacap asdacap approved these changes

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: node.switchLocal: System.UriFormatException: Invalid URI: The format of the URI could not be determined.
4 participants
@deffrian @benaadams @asdacap @LukaszRozmej