Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf/valuekeccak snap code #5689

Merged
merged 4 commits into from
May 12, 2023
Merged

Perf/valuekeccak snap code #5689

merged 4 commits into from
May 12, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented May 12, 2023

  • Swap Keccak with ValueKeccak in snap codes.
  • Dissappointingly does not reliably increase or decrease memory alloc or cpu.

Changes

  • Swapped Keccak with ValueKeccak in snap handling code along with response and request model.
  • Other minor change to reduce change needed to make this work.

Types of changes

What types of changes does your code introduce?

  • Optimization
  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No: Modified tests though.

Notes on testing

  • Can finish snap/state sync just fine. Did not reliably affect performance.

Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dissappointingly does not reliably increase or decrease memory alloc or cpu.

The effects will be on the otherside by decreasing the number of allocated objects the GC needs to consider when cleaning up memory, so hopefully lower GC times

@asdacap asdacap merged commit 0c938e1 into master May 12, 2023
@asdacap asdacap deleted the perf/valuekeccak-snap-code branch May 12, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants