Feature/disable wal flag #5702
Merged
Feature/disable wal flag #5702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
May 16, 2023
| @@ -182,6 +182,8 @@ protected virtual void RunPruning(IPruningContext pruning, Keccak statRoot) | |||
| writeFlags = WriteFlags.None; | |||
| } | |||
|
|
|||
| writeFlags |= WriteFlags.DisableWAL; | |||
There was a problem hiding this comment.
Why not start with it and then set LowPriority based on _pruningConfig.FullPruningDisableLowPriorityWrites ?
Comment on lines
+38
to
+41
| private WriteOptions? _noWalWrite; | ||
| private WriteOptions? _lowPriorityAndNoWalWrite; | ||
| private WriteOptions? _lowPriorityWriteOptions; | ||
| private ReadOptions? _readAheadReadOptions = null; |
There was a problem hiding this comment.
Can/should they be static?
There was a problem hiding this comment.
Ah, WriteAheadLogSync is from config.
| @@ -499,9 +514,19 @@ public void Set(ReadOnlySpan<byte> key, byte[]? value, WriteFlags flags = WriteF | |||
|
|
|||
| public WriteOptions? WriteFlagsToWriteOptions(WriteFlags flags) | |||
| { | |||
| if (flags == WriteFlags.LowPriority) | |||
| if ((flags & WriteFlags.LowPriority) != 0 && (flags & WriteFlags.DisableWAL) != 0) | |||
There was a problem hiding this comment.
Either save flags to bool and reuse them or check for both flags in one go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DisableWALa better more universal term for flag would beNoDurable,NonDurable,DurabilityNotRequiredor something, but can't find a good one. Got idea?Changes
DisableWALwrite flag. Integrate with RocksDB, SnapSync and FullPruning.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Remarks
Optional. Remove if not applicable.