Perf/faster block load for receipt #5708
Conversation
| return memory.Value.FasterToArray(); | ||
| } | ||
|
|
||
| public static byte[] FasterToArray(this in Memory<byte> memory) |
There was a problem hiding this comment.
Naming could cause confusion, normally you expect a copy.
Minor: is the code layout readable here? Would prefer ? operator.
There was a problem hiding this comment.
What do you have in mind? AsArray, AsArrayOrCopy?
src/Nethermind/Nethermind.Serialization.Rlp/ReceiptRecoveryBlock.cs
Outdated
Show resolved
Hide resolved
| private Transaction? _txBuffer; | ||
|
|
||
| public Transaction GetNextTransaction() | ||
| { | ||
| if (_transactions != null) | ||
| { | ||
| return _transactions[_currentTransactionIndex++]; | ||
| } | ||
|
|
||
| Rlp.ValueDecoderContext decoderContext = new(_transactionData, true); | ||
| decoderContext.Position = _currentTransactionPosition; | ||
| TxDecoder.Instance.Decode(ref decoderContext, ref _txBuffer, RlpBehaviors.AllowUnsigned | RlpBehaviors.DisableLazyHash); | ||
| _currentTransactionPosition = decoderContext.Position; | ||
|
|
||
| return _txBuffer; |
There was a problem hiding this comment.
TransactionStruct? and then have a generic decoder that would work with ITransaction objects? This way we could reuse the code?
There was a problem hiding this comment.
Perhaps a follow up PR. Code in decoder is significant too.
| Data = (Memory<byte>?)data, | ||
| Type = Type, | ||
| AccessList = TryGetAccessList(), | ||
| ChainId = chainId, | ||
| MaxFeePerDataGas = MaxFeePerDataGas, | ||
| }; | ||
|
|
||
| if (data is null) | ||
| { | ||
| tx.Data = null; // Yes this is needed... really. Try a debugger. | ||
| } | ||
|
|
There was a problem hiding this comment.
Data = data is null ? data : (Memory<byte>?)data,
There was a problem hiding this comment.
Nope, does not work.
There was a problem hiding this comment.
Ah sorry meant: Data = data is null ? null : (Memory<byte>?)data
|
|
|
Did a mistake during benchmark as I forgot to remove a spinwait in KeccakF. Rerun benchmark. They are both CPU limited, likely at JSON serialization.
|
ReceiptRecoveryBlockclass which stores the tx's byte section as raw serializedMemory<byte>.GetNextTransactionwhich is used by block recovery.Transactioninstead of a ref struct, but reuse the object which turns out to be significant.DisableLazyHashrlp param, so that transaction hash is calculated ahead of time as it will be needed.Transaction.Datafrombyte[]toMemory<byte>which can be backed by rocksdb's memory.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
eth_getLogs matches master.