Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stuck state from period offline #5710

Merged
merged 3 commits into from
May 26, 2023
Merged

Fix stuck state from period offline #5710

merged 3 commits into from
May 26, 2023

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented May 19, 2023 •
edited
Loading

Changes

  • Fix if node is offline too long it ceases to be able to sync properly if pivots move

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams marked this pull request as ready for review May 19, 2023 15:58
@benaadams benaadams changed the title Fix state not downloaded yet Fix stuck state from period offline May 19, 2023
@benaadams benaadams force-pushed the Fix-stateNotDownloadedYet branch from c41edad to 8b6caa0 Compare May 23, 2023 17:05
@benaadams benaadams added the bug label May 23, 2023
@benaadams benaadams mentioned this pull request May 25, 2023
Open
@benaadams benaadams merged commit b7f222d into master May 26, 2023
@benaadams benaadams deleted the Fix-stateNotDownloadedYet branch May 26, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@kamilchodola kamilchodola Awaiting requested review from kamilchodola

Assignees
No one assigned
Labels
bug include in 1.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benaadams @MarekM25 @LukaszRozmej