Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One more Engine API test: Blocks_before_pivots_should_not_be_added #5719

Merged
merged 3 commits into from
May 22, 2023
Merged

One more Engine API test: Blocks_before_pivots_should_not_be_added #5719

merged 3 commits into from
May 22, 2023

Conversation

MarekM25
Copy link
Contributor

Changes

  • Covered one more if in NewPayloadHandler in order to fix it in the next PR.
  • Refactored tests to handle post-merge blocks easier.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: More tests

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@MarekM25 MarekM25 marked this pull request as draft May 22, 2023 15:51
@MarekM25
Copy link
Contributor Author

It fails existing test so marking as a draft for now

@MarekM25 MarekM25 marked this pull request as ready for review May 22, 2023 20:00
@MarekM25 MarekM25 merged commit a515c06 into master May 22, 2023
@MarekM25 MarekM25 deleted the bugfix/pivot_newPayload branch May 22, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarekM25 @benaadams