Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pivot-related edge case that could lead to node corruption #5724

Merged
merged 6 commits into from
May 24, 2023

Conversation

MarekM25
Copy link
Contributor

Changes

Scenario:

  • Node offline on block X
  • The update of Nethermind and sync pivot is on block X + 100
  • Node won't be able to catch up with the tip of the chain without this fix because blocks (X, X+100) will be rejected as Pre-Pivot blocks and we won't download them
  • In the following scenario, a node without this fix node won't work and resync will be required.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@MarekM25 MarekM25 requested a review from LukaszRozmej May 23, 2023 09:03
@MarekM25 MarekM25 assigned asdacap and unassigned asdacap May 23, 2023
@MarekM25 MarekM25 changed the title Fixed pivot related edge case that could lead to node corruption Fixed pivot-related edge case that could lead to node corruption May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants