Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed fail on precompile dll import error #5725

Merged
merged 6 commits into from
May 26, 2023

Conversation

Demuirgos
Copy link
Contributor

Fixes Closes Resolves #

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

  • Rethrow Exception on DllNotFound exception instead of silently handling it

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@Demuirgos Demuirgos changed the title Fix/fail on dll import error Fixed fail on precompile dll import error May 23, 2023
@Demuirgos Demuirgos self-assigned this May 23, 2023
@Demuirgos Demuirgos marked this pull request as ready for review May 24, 2023 13:07
@Demuirgos Demuirgos requested a review from rubo May 24, 2023 13:08
@Demuirgos Demuirgos merged commit b997407 into master May 26, 2023
@Demuirgos Demuirgos deleted the Fix/Fail-On-DllImport-Error branch May 26, 2023 00:51
kamilchodola pushed a commit that referenced this pull request May 29, 2023
* - Rethrow DllNotFoundException when encountered on call sight in Precompile execution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants