Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce exceptions in Evm #5727

Merged
merged 8 commits into from
May 26, 2023
Merged

Reduce exceptions in Evm #5727

merged 8 commits into from
May 26, 2023

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented May 23, 2023 •
edited
Loading

Changes

  • Reduce exceptions in Evm processing (caused via revert decoding); as they are expensive
image

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams mentioned this pull request May 23, 2023
Closed
12 tasks
MarekM25
MarekM25 reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the must-have step after EVM optimization is running fuzzer. Next week I will talk with EF guys about how we can do it.

The step that we can do now is running hive consensus tests

LukaszRozmej
LukaszRozmej reviewed May 24, 2023
View reviewed changes
src/Nethermind/Nethermind.Evm/TransactionSubstate.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/TransactionSubstate.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/VirtualMachine.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/Tracing/ITxTracer.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/VirtualMachine.cs Outdated Show resolved Hide resolved
@benaadams
Copy link
Member Author

Hive tests
Hive consensus tests

@benaadams
Copy link
Member Author

Hive and Consensus (run timeout) issues unrelated

@LukaszRozmej
Copy link
Member

Hive and Consensus (run timeout) issues unrelated

You are 100% positive on that?

@benaadams
Copy link
Member Author

Hive and Consensus (run timeout) issues unrelated

You are 100% positive on that?

Yeah following up with Hive team; also have same issues on master (timeouts, etc)

@benaadams benaadams merged commit 8ab99ff into master May 26, 2023
@benaadams benaadams deleted the evm-exceptions branch May 26, 2023 13:33
@LukaszRozmej LukaszRozmej mentioned this pull request Jun 5, 2023
Closed
@benaadams benaadams mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@asdacap asdacap Awaiting requested review from asdacap

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benaadams @LukaszRozmej @MarekM25