Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keccaks: Skip unneeded array allocations #5735

Merged
merged 1 commit into from
May 27, 2023
Merged

Keccaks: Skip unneeded array allocations #5735

merged 1 commit into from
May 27, 2023

Conversation

benaadams
Copy link
Member

Changes

  • Now Keccak isn't backed by a separate array; using .ToArray to construct from a Span is just an unneeded allocation

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@benaadams benaadams requested review from asdacap and LukaszRozmej May 26, 2023 22:41
asdacap
asdacap approved these changes May 27, 2023
View reviewed changes
Copy link
Contributor

@asdacap asdacap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benaadams benaadams merged commit b00f661 into master May 27, 2023
@benaadams benaadams deleted the Keccak.ToArray branch May 27, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdacap asdacap asdacap approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @asdacap