Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less contention for OldReceipts and OldBodies #5737

Merged
merged 11 commits into from
May 30, 2023
Merged

Less contention for OldReceipts and OldBodies #5737

merged 11 commits into from
May 30, 2023

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented May 28, 2023 •
edited
Loading

Changes

  • Make FastBlockStatusList methods atomic reducing lock requirements
  • Increase some LruCache sizes to match the scan length + n

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

LukaszRozmej
LukaszRozmej requested changes May 29, 2023
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allows for duplicate sends which might cause more harm than good.

src/Nethermind/Nethermind.Synchronization/FastBlocks/FastBlockStatusList.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Synchronization/FastBlocks/ReceiptsSyncFeed.cs Show resolved Hide resolved
src/Nethermind/Nethermind.Synchronization/FastBlocks/SyncStatusList.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Synchronization/FastBlocks/SyncStatusList.cs Outdated Show resolved Hide resolved
@benaadams benaadams requested a review from LukaszRozmej May 30, 2023 12:04
@benaadams benaadams changed the title Less contention for receipts and bodies Less contention for OldReceipts and OldBodies May 30, 2023
@LukaszRozmej
Less contention for OldReceipts and OldBodies - Improve atomicity, si…
619e4b8 
…mplify API, increase readability (#5741)

* Improve atomicity, simplify API, increase readability

* use ReadValue & WriteValue in value setter

* more readability

* Bring back cache but only for failed downloads

* Add LowestInsertWithoutGaps synchronization
@benaadams benaadams merged commit e34ad2d into master May 30, 2023
@benaadams benaadams deleted the Less-contention branch May 30, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@asdacap asdacap Awaiting requested review from asdacap

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej