Fix gas fees accounting in TransactionProcessor.Trace

src/Nethermind/Nethermind.Evm.Test/TransactionProcessorTraceTest.cs

@@ -0,0 +1,29 @@
+// SPDX-FileCopyrightText: 2023 Demerzel Solutions Limited
+// SPDX-License-Identifier: LGPL-3.0-only
+
+using FluentAssertions;
+using Nethermind.Core;
+using Nethermind.Core.Test.Builders;
+using Nethermind.Evm.Tracing.ParityStyle;
+using Nethermind.Int256;
+using Nethermind.Specs;
+using NUnit.Framework;
+
+namespace Nethermind.Evm.Test;
+
+public class TransactionProcessorTraceTest : VirtualMachineTestsBase
+{
+    protected override long BlockNumber => MainnetSpecProvider.GrayGlacierBlockNumber;
+    protected override ulong Timestamp => MainnetSpecProvider.ShanghaiBlockTimestamp;
+
+    [TestCase(21000)]
+    [TestCase(50000)]
+    public void Traces_gas_fess_properly(long gasLimit)
+    {
+        (Block block, Transaction transaction) = PrepareTx(BlockNumber, gasLimit);
+        ParityLikeTxTracer tracer = new(block, transaction, ParityTraceTypes.All);
+        _processor.Trace(transaction, block.Header, tracer);
+        var senderBalance = tracer.BuildResult().StateChanges[TestItem.AddressA].Balance;
+        (senderBalance.Before - senderBalance.After).Should().Be((UInt256)21000 + transaction.Value);
+    }
+}

src/Nethermind/Nethermind.Evm.Test/VirtualMachineTestsBase.cs

@@ -118,7 +118,7 @@ protected TestAllTracerWithOutput Execute(long blockNumber, long gasLimit, byte[
         protected (Block block, Transaction transaction) PrepareTx(
             long blockNumber,
             long gasLimit,
-            byte[] code,
+            byte[] code = null,
             SenderRecipientAndMiner senderRecipientAndMiner = null,
             int value = 1,
             long blockGasLimit = DefaultBlockGasLimit,
@@ -140,7 +140,11 @@ protected TestAllTracerWithOutput Execute(long blockNumber, long gasLimit, byte[
                 TestState.CreateAccount(senderRecipientAndMiner.Recipient, 100.Ether());
             else
                 TestState.AddToBalance(senderRecipientAndMiner.Recipient, 100.Ether(), SpecProvider.GenesisSpec);
-            TestState.InsertCode(senderRecipientAndMiner.Recipient, code, SpecProvider.GenesisSpec);
+
+            if (code is not null)
+            {
+                TestState.InsertCode(senderRecipientAndMiner.Recipient, code, SpecProvider.GenesisSpec);
+            }
 
             GetLogManager().GetClassLogger().Debug("Committing initial state");
             TestState.Commit(SpecProvider.GenesisSpec);

src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs

@@ -241,7 +241,7 @@ private void Execute(Transaction transaction, BlockHeader block, ITxTracer txTra
                 }
             }
 
-            UInt256 senderReservedGasPayment = noValidation ? UInt256.Zero : (ulong)gasLimit * effectiveGasPrice;
+            UInt256 senderReservedGasPayment = (ulong)gasLimit * effectiveGasPrice;
 
             if (notSystemTransaction)
             {