Add a master build docker image for each commit on master branch

[kamilchodola]

Changes

• Build docker image with "master" tag on each commit (for tests usage)

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

[FalcoXYZ]

What happens when I push documentation changes to master? Will this trigger a build? If yes, we should reconsider this "build image on master push" trigger.

[kamilchodola]

@FalcoXYZ
Docs change is out of repo I think. So it won't trigger it I think.
I think changes which are not touch code are rare enough (maybe we can think of skipping ones which are changing only yamls, not cs files)

[FalcoXYZ]

@FalcoXYZ Docs change is out of repo I think. So it won't trigger it I think. I think changes which are not touch code are rare enough (maybe we can think of skipping ones which are changing only yamls, not cs files)

Sorry, I meant anything non-code related. Even if a simple refactor of text (for example) or changing some Github Action.

[kamilchodola]

@FalcoXYZ
Yup it will trigger it then - maybe not needed. I can set trigger which will trigger only when cs file is changed liek this:
paths:
- '**.cs'

[kamilchodola]

@FalcoXYZ
Added like this:
paths:
- '.cs'
- '.csproj'
- '.sln'
- '.config'
- '**.json'

[rubo]

Let's change to:

push:
  branches: [master]
paths:
  - 'src/Nethermind/**'

[kamilchodola]

Done :)

[kamilchodola]

We need to have same think for tests... It triggers every time I commit :/

[rubo]

What about adding

- '!src/Nethermind/*.Test'

[kamilchodola]

This will limit this one a bit.
but I meant that look below - I'd add some change to yaml and all nethermind unit tests will be triggered - this is worse than those micro optimizations :)

[rubo]

I thought you mean you don't wanna trigger Docker build on any test commit. Well, if you mean that each PR commit triggers required tests, then it is what it is. As they are required, they must run anyway. Otherwise, we need to make them not required.

[gat786]

If you are building this on every commit on master branch it would make sense to add commit hash to tag of that build so as to quickly be able to view which commit triggered what image when going through a list of images built.

[kamilchodola]

@gat786 If I'd add a commit hash to tag, then it would be hard to trigger tests with latest master since I'd not be able to distinguish a name of a docker tag to use in external source.

[gat786]

Ok