Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/Split dispatcher and downloader #5778

Merged
merged 11 commits into from
Jun 6, 2023
Merged

Refactor/Split dispatcher and downloader #5778

merged 11 commits into from
Jun 6, 2023

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Jun 5, 2023

  • Includes Perf/release peer early #5772
  • Split sync specific logic from SyncDispatcher into its own class which inherit ISyncDownloader.
  • Remove the need to forward SyncDispatcher's parameter.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Syncing....

@asdacap asdacap merged commit 3a96f5e into master Jun 6, 2023
@asdacap asdacap deleted the refactor/dont-inherit-sync-dispatcher branch June 6, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @LukaszRozmej