Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast test for balance < tx.Value + gas #5783

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Conversation

benaadams
Copy link
Member

Changes

  • Will be currently be rejected later in pipeline by BalanceTooLowFilter; however that iterates and considers all txs from the account; can do an earlier reject in BalanceZeroFilter just for the current tx in solation

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@marcindsobczak
Copy link
Contributor

Actually it was fine before last commit (Use correct gas calc) 😄

@benaadams benaadams merged commit 747ed0b into master Jun 9, 2023
@benaadams benaadams deleted the Txn-fast-check branch June 9, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants