Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary disable Cancun engine_ APIs #5787

Closed
wants to merge 1 commit into from

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Jun 7, 2023

Hide problematic EIP-4844 capabilities

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

@benaadams benaadams added the bug label Jun 7, 2023
@rubo rubo self-requested a review June 7, 2023 15:56
Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, why is this targeting the release/1.19.1 branch?

Also, tests need to be updated as well.

@flcl42
Copy link
Contributor Author

flcl42 commented Jun 7, 2023

@rubo can be a candidate for 1.19.2 hotfix release.

@flcl42 flcl42 changed the base branch from release/1.19.1 to master June 7, 2023 17:24
@flcl42 flcl42 changed the base branch from master to release/1.19.1 June 7, 2023 17:24
@rubo
Copy link
Contributor

rubo commented Jun 7, 2023

@rubo can be a candidate for 1.19.2 hotfix release.

It always goes to the master and then cherry-picked to somewhere else unless it's branch-specific.

@flcl42 flcl42 force-pushed the hotfix/disable-cancun-capabilties branch 2 times, most recently from 4982505 to dc240ab Compare June 7, 2023 18:10
@benaadams benaadams changed the base branch from release/1.19.1 to master June 7, 2023 18:21
@benaadams benaadams changed the base branch from master to release/1.19.1 June 7, 2023 18:22
@flcl42 flcl42 changed the base branch from release/1.19.1 to master June 7, 2023 20:10
@flcl42 flcl42 force-pushed the hotfix/disable-cancun-capabilties branch from dc240ab to ccfb601 Compare June 7, 2023 20:11
@MarekM25
Copy link
Contributor

MarekM25 commented Jun 8, 2023

Tbh I don't like this solution :) I will try to propose alternative one

@MarekM25
Copy link
Contributor

MarekM25 commented Jun 8, 2023

@rubo can be a candidate for 1.19.2 hotfix release.

It always goes to the master and then cherry-picked to somewhere else unless it's branch-specific.

this fix will break 4844 devnets, we can release 1.19.2 but to master we should do proper fixing

@rubo
Copy link
Contributor

rubo commented Jun 8, 2023

this fix will break 4844 devnets, we can release 1.19.2 but to master we should do proper fixing

If so, then this PR should target the new release branch when it is ready.

@MarekM25 MarekM25 changed the base branch from master to release/1.19.2 June 9, 2023 08:08
@MarekM25 MarekM25 requested a review from a team as a code owner June 9, 2023 08:08
@MarekM25 MarekM25 changed the base branch from release/1.19.2 to master June 9, 2023 08:09
@MarekM25
Copy link
Contributor

MarekM25 commented Jun 9, 2023

Cherry-picked to release branch: https://github.com/NethermindEth/nethermind/tree/release/1.19.2

@flcl42 flcl42 closed this Jun 12, 2023
@flcl42 flcl42 deleted the hotfix/disable-cancun-capabilties branch October 13, 2023 14:11
@flcl42 flcl42 restored the hotfix/disable-cancun-capabilties branch October 13, 2023 14:11
@rubo rubo deleted the hotfix/disable-cancun-capabilties branch December 20, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants