-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary disable Cancun engine_ APIs #5787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on, why is this targeting the release/1.19.1
branch?
Also, tests need to be updated as well.
@rubo can be a candidate for 1.19.2 hotfix release. |
It always goes to the |
4982505
to
dc240ab
Compare
dc240ab
to
ccfb601
Compare
Tbh I don't like this solution :) I will try to propose alternative one |
this fix will break 4844 devnets, we can release 1.19.2 but to master we should do proper fixing |
If so, then this PR should target the new release branch when it is ready. |
Cherry-picked to release branch: https://github.com/NethermindEth/nethermind/tree/release/1.19.2 |
Hide problematic EIP-4844 capabilities
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing