Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move detailed peer logging to debug, add diversity #5795

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Conversation

benaadams
Copy link
Member

Changes

  • Move detailed (line per peer) to Debug
  • Add diversity to single line logs
2023-06-09 06:42:15.8209|Allocated sync peers 72(72)/100 | Geth (51.39 %), Nethermind (30.56 %), erigon (13.89 %), besu (2.78 %), Unknown (1.39 %)
2023-06-09 06:42:30.9419|Peers | with known best block: 71 | all: 71 | Geth (52.11 %), Nethermind (30.99 %), erigon (14.08 %), besu (2.82 %)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Logging changes

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I am lacking here is some summary of allocation types. Could be good for diagnosing syncing issues.

@benaadams
Copy link
Member Author

One thing I am lacking here is some summary of allocations. Couild be good for diagnosing syncing issues.

Not sure what you mean? Could you provide example?

@LukaszRozmej
Copy link
Member

One thing I am lacking here is some summary of allocations. Couild be good for diagnosing syncing issues.

Not sure what you mean? Could you provide example?

Summary of this column
obraz

@benaadams
Copy link
Member Author

One thing I am lacking here is some summary of allocation types. Could be good for diagnosing syncing issues.

Added

Allocated sync peers 55(55)/100 | Active: None | Sleeping: All | Geth (47.27 %), Nethermind (32.73 %), Erigon (20.00 %)

Will get example from syncing when do it again

@benaadams benaadams merged commit ce26652 into master Jun 12, 2023
@benaadams benaadams deleted the Peer-logging branch June 12, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants