Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of chainspec tests & handle chainspec exceptions #5819

Merged
merged 13 commits into from
Jun 15, 2023

Conversation

MarekM25
Copy link
Contributor

@MarekM25 MarekM25 commented Jun 15, 2023

Resolves #5542

  • More chainspec tests
  • Handled gnosis exceptions

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@MarekM25 MarekM25 requested a review from rubo June 15, 2023 13:03
@MarekM25 MarekM25 marked this pull request as ready for review June 15, 2023 15:08
@MarekM25 MarekM25 merged commit 7b342cb into master Jun 15, 2023
@MarekM25 MarekM25 deleted the gnosis_spec_provider branch June 15, 2023 15:08
kamilchodola pushed a commit that referenced this pull request Jun 26, 2023
* Working on GnosisSpecProvider

* Passed test

* More GetSpec checks

* Working on gnosis exceptions

* handle gnosis exceptions

* cosmetic

* refactoring chainspec loading

* chainspec tests refactoring

* chainspec tests refactoring

* whitespace fix

* fix test

* whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GnosisSpecProvider, compare spec tests and Shanghai EIPs exceptions
2 participants