Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed eip2537 activation #5824

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Fixed eip2537 activation #5824

merged 2 commits into from
Jun 19, 2023

Conversation

MarekM25
Copy link
Contributor

Changes

-fixed bugfix for EIP2537 activation
-added test that will control the list of properties in two classes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@MarekM25 MarekM25 added the bug label Jun 16, 2023
@MarekM25 MarekM25 requested review from rubo and deffrian June 16, 2023 14:20
@MarekM25 MarekM25 merged commit b2114af into master Jun 19, 2023
@MarekM25 MarekM25 deleted the bugfix/eip2537_activation branch June 19, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deffrian deffrian deffrian approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@rubo rubo rubo approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarekM25 @rubo @LukaszRozmej @deffrian