Remove v of non-legacy tx signature from RPC response
#5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jul 13, 2023
@LukaszRozmej Please see the remarks |
Since causes issue in major 3rd party lib should this be a candidate for pulling into 1.20.0? |
@benaadams Yes |
MarekM25
approved these changes
Jul 13, 2023
|
Note that this PR alone won't address ethers' issue as it doesn't handle |
kamilchodola
pushed a commit
that referenced
this pull request
Jul 14, 2023
16 tasks
kamilchodola
added a commit
that referenced
this pull request
Aug 1, 2023
* Add missing peer types to limits (#5838) * Add missing peer types to limits * Add Reth * Flaky test * Use better processing timer for logging (#5843) * Use different processing timer * Use single queue * Revert to simpler * Add Gnosis Shanghai hard-fork timestamp (#5848) * Don't use DarkGray (#5849) * Bump to 1.20.0-rc * MaxDegreeOfParallelism defaults for full pruning (#5662) * other defaults for full pruning? * degreeOfParalleism * small refactor * fix build * Fixing BatchedTrieVistior * 25% of cores * Update Pruning config * add logger * fix * Perf/smoother peer discovery (#5846) * Continuously connect * Added another delay due to disconnect * Increase useless peer timeout * Simple rate limiter * Integrate with peer manager * Adjust some stats * Check all peer, and uses pending variable * Make logic clearer * Minor cleanup * Missed cancellation token * Cancel setup outgoing peer connection if throttled * Lockless ratelimiter * Addressing comment * Minor adjustments * Whitespace * Having trouble getting candidate at higher speed * Make test more consistent * Even more lenient (cherry picked from commit 6ab0a3a) * Update RocksDB package (#5883) (cherry picked from commit 4e2bf0f) * Update DotNetty feed (cherry picked from commit 3e330ad) * Update DotNetty package (cherry picked from commit 47a92ee) * add more gnosis bootnodes (#5910) (cherry picked from commit b7086a9) * Remove `v` of non-legacy tx signature from RPC response (#5927) * minor fixes * Update version to 1.20.0 * Bump to 1.20.1 * Restore `v` in tx signature for Geth compatibility (#5937) * Restore DotNetty feed (#5976) * Revert `nuget.config` * Update DotNetty package --------- Co-authored-by: Ben Adams <thundercat@illyriad.co.uk> Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com> Co-authored-by: Kamil Chodoła <kamil@nethermind.io> Co-authored-by: Marek Moraczyński <marekm2504@gmail.com> Co-authored-by: Amirul Ashraf <asdacap@gmail.com> Co-authored-by: Marcin Sobczak <marcindsobczak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed the
vcomponent of the non-legacy transaction signatures from the RPC response.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Also, needs manual testing.
Documentation
Requires documentation update
Requires explanation in Release Notes
Remarks
This fix should address the Nethermind's part of the issue with ethers v6.