Add holesky configs and chainspec #6034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilchodola
requested changes
Aug 23, 2023
MarekM25
reviewed
Aug 23, 2023
MarekM25
reviewed
Aug 23, 2023
MarekM25
reviewed
Aug 23, 2023
| "LogFileName": "holesky.logs.txt" | ||
| }, | ||
| "Sync": { | ||
| "FastSync": true |
There was a problem hiding this comment.
+SnapSync true?
I guess we have to add pivot, probably genesis block in this case. I haven't checked how pivots work with genesis though.
There was a problem hiding this comment.
Please check here
#6034 (comment)
There was a problem hiding this comment.
Okay, please make sure any network can work without pivots. I am not so sure about it. It would be nice to know not only in holesky context
MarekM25
reviewed
Aug 23, 2023
MarekM25
approved these changes
Aug 24, 2023
kamilchodola
approved these changes
Aug 25, 2023
kamilchodola
pushed a commit
that referenced
this pull request
Aug 28, 2023
* Add holesky configs and chainspec * fixes * Add tests and fix for 4788 address * adjust shanghai timestamp for holeskey to be genesis + (256*12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6032
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
#6033
Requires explanation in Release Notes
Release Notes: