Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Actions] Publish Docker: Replace '/' with '-' in docker image name #6286

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

brbrr
Copy link
Contributor

@brbrr brbrr commented Nov 21, 2023

Changes

  • fixes the issue with failing actions on release branch by making sure the tag name is in line with docker naming format

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@brbrr brbrr requested a review from a team November 21, 2023 17:25
@brbrr brbrr requested review from rubo and a team as code owners November 21, 2023 17:25
.github/workflows/publish-docker.yml Outdated Show resolved Hide resolved
@brbrr brbrr merged commit 9637860 into master Nov 21, 2023
62 checks passed
@brbrr brbrr deleted the fix/docker-publish-use-proper-image-name branch November 21, 2023 18:24
gr8h pushed a commit to fuseio/nethermind-client that referenced this pull request Dec 12, 2023
NethermindEth#6286)

* Replace '/' with '-' in docker image name

* Revert double quotes

---------

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
kamilchodola pushed a commit that referenced this pull request Dec 14, 2023
#6286)

* Replace '/' with '-' in docker image name

* Revert double quotes

---------

Co-authored-by: Ruben Buniatyan <rubo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants