-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flood comparision tool #6337
Merged
Merged
Flood comparision tool #6337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use different processing timer * Use single queue * Revert to simpler
(cherry picked from commit 3e330ad)
(cherry picked from commit 47a92ee)
Fix path Run on push temporarily Fix file path Fix inputs and missing vars All fields not required Inherit secrets when calling run-a-single-node-from-branch Add default for cl_client Use base_tag generated by run-a-single-node Download artifacts from other post-merge-smoke-tests Remove the old download-artifact Change the name of token secret Remove usage of external action Allow to specify smoke tests branch to use Remove additional option to fit dispatch limit fix: wrong inputs string format Export run id Fix rpc url Fix debug Add runner's ip to `allowed_ips` Maximum 10 inputs is allowed in workflow_dispatch Add allowed_ips to workflow_dispatch inputs Try to join two ips Print `,` conditionally Update public-ip Debug Use VPN Add wireguard.conf Fix location Checkout the repository before installing wireguard Update wireguard.conf to match nethermind repo secrets Update environment variables to match secrets Install flood before wireguard Use include in matrix to specify both name and address Revert "Use include in matrix to specify both name and address" This reverts commit 71caa0c.
For github hosted runners time limit for a job is 6 hours. It is less than a node needs to sync. Thus we wait 5.5 hours before checking the sync status of node.
…dEth/nethermind into rpc-comparision-1.23.0
kamilchodola
requested review from
smartprogrammer93,
benaadams,
piwonskp,
a team and
rubo
and removed request for
a team and
rubo
December 6, 2023 18:02
stdevMac
approved these changes
Dec 8, 2023
brbrr
approved these changes
Dec 8, 2023
main_branch_file="rpc_url%${{ env.CLEAN_MAIN_REF }}%${{ github.run_id }}.txt" | ||
compare_branch_file="rpc_url%${{ env.CLEAN_COMPARE_REF }}%${{ github.run_id }}" | ||
|
||
ls artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a leftover from testing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool allows to test RPC with flood (https://github.com/paradigmxyz/flood/) - it is executing RPC tests comparing Your base to the selected node.
In case of this action it allows to compare with:
Some changes may still be needed but would appear when developers would start using it more extensively.
Also PR to proper flood repo is needed to make test data more dynamic (currently working on Piotr fork).
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes