-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce chiseled Docker image #6467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubo
force-pushed
the
feature/chiseled
branch
from
January 13, 2024 00:51
dbaed30
to
aaa833b
Compare
matilote
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the Docker/workflows side
stdevMac
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6567
Changes
This PR introduces an additional chiseled rootless Docker image for enhanced security:
Dockerfile.chiseled
As chiseled images don't support package managers to install Snappy required by some of Nethermind components, those components have been updated not to require Snappy installation as follows:
The RocksDB package has been replaced with Nethermind.RocksDB.Runtimes package that uses the official binaries from Meta that don't require Snappy installationThese changes greatly simplify Nethermind installation and docs, eliminating any prerequisites that are especially annoying for RHEL-like distros.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
This PR must be tested thoroughly on all the supported platforms and CPU architectures.
Documentation
Requires documentation update
Requires explanation in Release Notes