Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations in StorageRangesMessageSerializer #6534

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Reduce allocations in StorageRangesMessageSerializer #6534

merged 2 commits into from
Jan 14, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Capture closures once per class rather than once per invocation
  • Change PathWithStorageSlot from class to readonly struct

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@benaadams benaadams marked this pull request as ready for review January 13, 2024 20:16
@benaadams benaadams marked this pull request as draft January 13, 2024 20:49
@benaadams benaadams marked this pull request as ready for review January 14, 2024 02:31
@benaadams benaadams merged commit 864d265 into master Jan 14, 2024
67 checks passed
@benaadams benaadams deleted the StorageRangesMessageSerializer branch January 14, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asdacap asdacap asdacap approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

@damian-orzechowski damian-orzechowski Awaiting requested review from damian-orzechowski

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @asdacap