Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect timed out connects #6594

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

benaadams
Copy link
Member

Resolves #6465

Changes

  • If connect timesout; cancel/close the connecting socket

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • No

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in the end we do connect, weird, should we try to recover the connection?

@benaadams
Copy link
Member Author

So in the end we do connect, weird, should we try to recover the connection?

🤷‍♂️ Shouldn't leave a floating socket hanging aroud in the ether; just because the timeout finishes doesn't me the socket doesn't connect eventually

@LukaszRozmej
Copy link
Member

So in the end we do connect, weird, should we try to recover the connection?

🤷‍♂️ Shouldn't leave a floating socket hanging aroud in the ether; just because the timeout finishes doesn't me the socket doesn't connect eventually

But it should timeout itself: https://github.com/NethermindEth/nethermind/pull/6594/files#diff-86b8218c02ef77c7e74cd114c0d6be18c976da957e6667d7bc9a2e2370ee1befR171

@benaadams
Copy link
Member Author

So in the end we do connect, weird, should we try to recover the connection?

🤷‍♂️ Shouldn't leave a floating socket hanging aroud in the ether; just because the timeout finishes doesn't me the socket doesn't connect eventually

But it should timeout itself: https://github.com/NethermindEth/nethermind/pull/6594/files#diff-86b8218c02ef77c7e74cd114c0d6be18c976da957e6667d7bc9a2e2370ee1befR171

Should still depose it

@benaadams benaadams merged commit 8191870 into master Jan 23, 2024
67 checks passed
@benaadams benaadams deleted the Disconnect-timed-out-connects branch January 23, 2024 11:16
marcindsobczak pushed a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too many close_wait
2 participants