Perf/background task scheduler #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdacap
changed the title
benaadams
reviewed
Feb 7, 2024
src/Nethermind/Nethermind.Consensus/Scheduler/BackgroundTaskScheduler.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Scheduler/BackgroundTaskScheduler.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V62/Eth62ProtocolHandler.cs
Outdated
Show resolved
Hide resolved
benaadams
approved these changes
Feb 7, 2024
| } | ||
|
|
||
| protected BlockHeadersMessage FulfillBlockHeadersRequest(GetBlockHeadersMessage msg) | ||
| protected Task<BlockHeadersMessage> FulfillBlockHeadersRequest(GetBlockHeadersMessage msg, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Why Task in the first place? Why not ValueTask if really needed?
There was a problem hiding this comment.
My understanding is that Task should still be the default unless it has been shown that ValueTask improve performance.
| { | ||
| Array.Resize(ref blocks, i + 1); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| return new BlockBodiesMessage(blocks); | ||
| return Task.FromResult(new BlockBodiesMessage(blocks)); |
There was a problem hiding this comment.
can we move from Array->ArrayPoolList?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a general purpose scheduler for running background tasks.
Effect
(after, before), OldBlocks and OldReceipts.
Looks more like it got worst. could just be that I was using the desktop before.
Snap serving barely have any effect in the first place.
With this background thread scheduler, I've no idea if it do something or it is just noise.
It does serve 25% more nodes per second though.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Documentation
Requires documentation update
Requires explanation in Release Notes
Yes
No
Schedule background task to not occur during block processing.